params: flash: erase corrupt sector #24065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkueng
previously approved these changes
Dec 3, 2024
dakejahl
commented
Dec 3, 2024
bkueng
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When updating from Ardupilot to PX4 on a board that uses flash based params PX4 will fail to load params. It will continue to fail until the MCU is mass erased. This is because the params sector contains the Ardupilot param format.
Solution
Erase parameter sector if
parameters_tokenis not found. This essentially tells us that the sector is not in the proper format and therefore we assume it is generally "corrupted". This is what Ardupilot does and doesn't have this issue.Testing
Tested on an ARK FPV.